Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Admin API Credentials vertical #556

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Feb 7, 2025

What this PR changes/adds

adds the Credentials API to the Issuer Service Admin API. This includes credential revocation

Why it does that

Admin API to revoke... Credentials

Further notes

  • renamed StatusListService -> CredentialService, because it now also has methods to query

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #536

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request api labels Feb 7, 2025
@paullatzelsperger paullatzelsperger force-pushed the feat/admin-credentials-vertical branch from afc12be to 4cab95e Compare February 7, 2025 06:55
@paullatzelsperger paullatzelsperger force-pushed the feat/admin-credentials-vertical branch from 4cab95e to e8d2c3e Compare February 7, 2025 06:58
@paullatzelsperger paullatzelsperger force-pushed the feat/admin-credentials-vertical branch 2 times, most recently from f49c9e9 to 0e641b8 Compare February 7, 2025 07:29
@paullatzelsperger paullatzelsperger force-pushed the feat/admin-credentials-vertical branch from 0e641b8 to 99e2671 Compare February 7, 2025 07:35
@paullatzelsperger paullatzelsperger marked this pull request as ready for review February 7, 2025 08:35
@paullatzelsperger paullatzelsperger force-pushed the feat/admin-credentials-vertical branch from a3b0a4e to 9616484 Compare February 7, 2025 08:36
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paullatzelsperger paullatzelsperger merged commit eb2fa88 into eclipse-edc:main Feb 7, 2025
17 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/admin-credentials-vertical branch February 7, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IssuerService: implement Credential vertical
3 participants